WebSafe 3.7github.com
|
|
🏠
Skip to content

ORDER BY variable validation#2860

Open
raz-mon wants to merge 16 commits intomasterfrom
order-by-aggregation-validations
Open

ORDER BY variable validation#2860
raz-mon wants to merge 16 commits intomasterfrom
order-by-aggregation-validations

Conversation

@raz-mon
Copy link
Collaborator

@raz-mon raz-mon commented Feb 1, 2023

Validates that when an aggregation is used in a projection of a WITH\RETURN clause followed by an ORDER-BY clause, then the variables used in the ORDER BY clause are one of the projected variables only (either an aggregation expression or a projection)

doc-fix

fix

added AR_EXP_Equal func

some fixes
@raz-mon raz-mon changed the title added aggregated projections ordering validation ORDER BY variable validation Feb 1, 2023
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Patch coverage: 86.01% and project coverage change: -0.05 ⚠️

Comparison is base (4dc2050) 91.60% compared to head (d74a4d8) 91.56%.

❗ Current head d74a4d8 differs from pull request most recent head 18a6abf. Consider uploading reports for the commit 18a6abf to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2860      +/-   ##
==========================================
- Coverage   91.60%   91.56%   -0.05%     
==========================================
  Files         272      273       +1     
  Lines       26373    26563     +190     
==========================================
+ Hits        24160    24322     +162     
- Misses       2213     2241      +28     
Impacted Files Coverage Δ
src/commands/cmd_info.c 0.00% <0.00%> (ø)
src/module.c 67.74% <0.00%> (-3.23%) ⬇️
src/arithmetic/arithmetic_expression.c 92.65% <74.28%> (-1.42%) ⬇️
src/arithmetic/string_funcs/string_funcs.c 97.25% <92.14%> (-2.15%) ⬇️
...n_plan/execution_plan_build/build_projection_ops.c 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@raz-mon raz-mon requested a review from swilly22 February 13, 2023 10:06
@raz-mon raz-mon requested a review from AviAvni February 22, 2023 08:18
@nafraf nafraf linked an issue Mar 24, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

Comments