WebSafe 3.7github.com
|
|
🏠
Skip to content

Update README.md#2983

Open
LiorKogan wants to merge 2 commits intomasterfrom
LiorKogan-patch-3
Open

Update README.md#2983
LiorKogan wants to merge 2 commits intomasterfrom
LiorKogan-patch-3

Conversation

@LiorKogan
Copy link
Member

@LiorKogan LiorKogan commented Mar 23, 2023

Fix build instructions.
README structure and build instructions are now similar to RTS and RB.

Fix build instruction.
Structure and build instructions are now similar to RTS and RB.
@LiorKogan LiorKogan requested review from rafie and swilly22 March 23, 2023 06:23
Comment on lines +44 to 57
First step is to have Redis installed, of course. The following, for example, builds Redis on a clean Ubuntu docker image (`docker pull ubuntu`):

```
mkdir ~/Redis
cd ~/Redis
apt-get update -y && apt-get upgrade -y
apt-get install -y wget make pkg-config build-essential
wget https://download.redis.io/redis-stable.tar.gz
tar -xzvf redis-stable.tar.gz
cd redis-stable
make distclean
make
make install
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. To build RedisGraph we don't need Redis.
  2. apt-get isn't available on all Linux distros

I wouldn't mention this step.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course people who already have Redis can skip this part, but the assumption here is that many people don't have Redis yet, and we want to instruct them how to start from nothing and reach the point were they have RedisGraph running.

Re apt-get - true, but as I stated - this is an example were you start with a clean Ubuntu docker image.

And again - we have similar build instructions for RTS and RB now. There were many issues like #2982 across all modules - and I believe it is now solved for RTS and RB (anyway - I'll keep syncing all 3 repos on new issues).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also have few notes about this. Sent a DM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

Comments