Only call curl_close() on PHP < 8#4125
Merged
antonmedv merged 2 commits intodeployphp:masterfrom Oct 23, 2025
jamieburchell:fix-curl-close-php8
Merged
Only call curl_close() on PHP < 8#4125antonmedv merged 2 commits intodeployphp:masterfrom jamieburchell:fix-curl-close-php8
antonmedv merged 2 commits intodeployphp:masterfrom
jamieburchell:fix-curl-close-php8
Conversation
antonmedv
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
curl_close()has had no effect since PHP 8.0 and is deprecated in PHP 8.5. This patch ensures that it is only called in PHP < 8. Note a separate commit for Httpie as this may want to be handled by upgrading the library.