Make seek work on /dev/null#22886
Merged
sbc100 merged 2 commits intoemscripten-core:mainfrom Nov 18, 2024
Merged
Conversation
4 tasks
hoodmane
force-pushed
the
dev-null-seek
branch
from
5f57b19 to
0ada290
Compare
Collaborator
Author
|
Okay I moved the test to |
sbc100
approved these changes
Nov 14, 2024
Collaborator
Author
|
Is the CI stuck here? |
Collaborator
|
Hmm.. can you try rebasing or merging, to see if it will trigger? |
Seeking `/dev/null` should work and do nothing instead of returning `EPIPE`. This fixes it.
auto-merge was automatically disabled
November 18, 2024 18:48
Head branch was pushed to by a user without write access
hoodmane
force-pushed
the
dev-null-seek
branch
from
0ada290 to
20b1a32
Compare
sbc100
approved these changes
Nov 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seeking
/dev/nullshould work and do nothing instead of returningEPIPE. This fixes it.