oidmap: make entry cleanup explicit in oidmap_clear#2169
Open
Seyi007 wants to merge 1 commit intogit:masterfrom
Open
oidmap: make entry cleanup explicit in oidmap_clear#2169Seyi007 wants to merge 1 commit intogit:masterfrom
Seyi007 wants to merge 1 commit intogit:masterfrom
Conversation
github-project-automation
bot
moved this to Todo
in Op-Amp Frequency Response and Applications Suite
|
There are issues in commit 4b47fa7:
|
Seyi007
force-pushed
the
improve-oidmap-clear-func
branch
from
4b47fa7 to
1f5e841
Compare
|
There is an issue in commit 1f5e841:
|
Seyi007
force-pushed
the
improve-oidmap-clear-func
branch
from
1f5e841 to
462048a
Compare
|
There is an issue in commit 462048a:
|
Replace oidmap's use of hashmap_clear_() and layout-dependent freeing with an explicit iteration and optional free callback. This removes reliance on struct layout assumptions while keeping the existing API intact. Add tests for oidmap_clear_with_free behavior. test_oidmap__clear_with_free_callback verifies that entries are freed when a callback is provided, while test_oidmap__clear_without_free_callback verifies that entries are not freed when no callback is given. These tests ensure the new clear implementation behaves correctly and preserves ownership semantics. Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com>
Seyi007
force-pushed
the
improve-oidmap-clear-func
branch
from
462048a to
422aaa6
Compare
subratakundu2312-web
left a comment
subratakundu2312-web
left a comment
There was a problem hiding this comment.
TANNY NANDY @ 270GMAIL .COM
|
ADD OFF FIND OR CHECK NO : 7500143 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.