gh-125633: Add function ispackage to stdlib inspect#125634
gh-125633: Add function ispackage to stdlib inspect#125634ncoghlan merged 14 commits intopython:mainfrom
ispackage to stdlib inspect#125634Conversation
nineteendo
left a comment
nineteendo
left a comment
There was a problem hiding this comment.
Can you add tests and fix the sphinx markup?
Misc/NEWS.d/next/Library/2024-10-17-04-52-00.gh-issue-125633.lMck06.rst
Outdated
Show resolved
Hide resolved
|
Please add a unittest and document. Also add to 3.14 what's new(recommend) |
|
One of the tests is currently failing because you also need to add the new test folder to the Makefile: Line 2500 in 7b04496 should be: test/test_inspect \
+ test/test_inspect/inspect_simple_pkg \ |
Xiaokang2022
changed the title
ispackage to stdlib inspectispackage to stdlib inspect
|
LGTM |
Misc/NEWS.d/next/Library/2024-10-17-04-52-00.gh-issue-125633.lMck06.rst
Outdated
Show resolved
Hide resolved
|
@brettcannon @ncoghlan: Is it the correct way to check if a module a package, |
|
I'm not sure Edit: after checking the This also keeps things consistent with the glossary's definition of a package as a module with a |
|
Thanks for the PR @Xiaokang2022, and thanks for the prior reviews all! |
| self.istest(inspect.ispackage, 'importlib') | ||
| self.assertFalse(inspect.ispackage(inspect)) | ||
| self.assertFalse(inspect.ispackage(mod)) | ||
| self.assertFalse(inspect.ispackage(':)')) |
There was a problem hiding this comment.
This last test genuinely made me laugh :)
…#125634) --------- Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
8 participants
ispackageto stdlibinspect#125633