gh-132825: Enhance unhashable error messages for dict and set#132828
Merged
cfbolz merged 2 commits intopython:mainfrom Apr 23, 2025
Merged
gh-132825: Enhance unhashable error messages for dict and set#132828cfbolz merged 2 commits intopython:mainfrom
cfbolz merged 2 commits intopython:mainfrom
Conversation
vstinner
requested review from
brettcannon,
ericsnowcurrently,
markshannon,
methane,
ncoghlan,
rhettinger and
warsaw
as code owners
vstinner
changed the title
Member
Author
Done: I replaced "Cannot ..." with "cannot ...". |
cfbolz
approved these changes
Apr 23, 2025
|
Thanks for this improvement! One minor nit: I like wordplays but I'm not sure if the T in unhashTable has been introduced on purpose? |
Member
Author
It wasn't done on purpose, it's a typo :-( I wrote #132847 to fix the typo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.