WebSafe 3.7github.com
|
|
🏠
Skip to content

gh-133610: Remove PyUnicode_AsDecoded/Encoded functions#133612

Merged
vstinner merged 8 commits intopython:mainfrom
StanFromIreland:rem-depr-uni-c-api
May 9, 2025
Merged

gh-133610: Remove PyUnicode_AsDecoded/Encoded functions#133612
vstinner merged 8 commits intopython:mainfrom
StanFromIreland:rem-depr-uni-c-api

Conversation

@StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented May 7, 2025 •
edited by bedevere-app bot
Loading

@StanFromIreland StanFromIreland requested a review from encukou as a code owner May 7, 2025 20:21
@StanFromIreland StanFromIreland changed the title Remove PyUnicode_AsDecoded/Encoded functions gh-133610: Remove PyUnicode_AsDecoded/Encoded functions May 7, 2025
@bedevere-app bedevere-app bot mentioned this pull request May 7, 2025
Closed
@StanFromIreland
Copy link
Member Author

StanFromIreland commented May 8, 2025 •
edited
Loading

cc @AA-Turner , @emmatyping for test_zstd fail https://github.com/python/cpython/actions/runs/14894216754/job/41833346355?pr=133612
@StanFromIreland
Copy link
Member Author

StanFromIreland commented May 8, 2025

Request: @vstinner
vstinner
vstinner reviewed May 8, 2025
View reviewed changes
@StanFromIreland StanFromIreland requested a review from vstinner May 8, 2025 15:02
vstinner
vstinner reviewed May 8, 2025
View reviewed changes
vstinner
vstinner approved these changes May 8, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@vstinner
Copy link
Member

vstinner commented May 9, 2025

Tests / Ubuntu (free-threading) / build and test (ubuntu-24.04) (pull_request)

test_zstd crash:

0:12:55 load avg: 14.73 [1/3/1] test_zstd worker non-zero exit code (Exit code -11 (SIGSEGV))
Re-running test_zstd in verbose mode (matching: test_compress_locking)
test_compress_locking (test.test_zstd.FreeThreadingMethodTests.test_compress_locking) ...

Fatal Python error: Fatal Python error: Segmentation faultSegmentation fault
@vstinner
Copy link
Member

vstinner commented May 9, 2025

A code search on PyPI top 8,000 projects found 2 projects, but there are only references to these 4 removed functions, these functions are not actually used. So we should be good in terms of impact.
@vstinner vstinner merged commit 4fd1095 into python:main May 9, 2025
43 checks passed
@StanFromIreland StanFromIreland deleted the rem-depr-uni-c-api branch May 9, 2025 15:33
@emmatyping
Copy link
Member

emmatyping commented May 9, 2025 •
edited
Loading

@vstinner @StanFromIreland the zstd crash is noted in #132983 (comment). I'm still trying to figure out the cause/fix for it.
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@StanFromIreland @Pranjal095
pythongh-133610: Remove PyUnicode_AsDecoded/Encoded functions (python…
f38f2be 
…#133612)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@StanFromIreland @taegyunkim
pythongh-133610: Remove PyUnicode_AsDecoded/Encoded functions (python…
1675141 
…#133612)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@StanFromIreland @vstinner @emmatyping

Comments