gh-120057: Add os.environ.refresh() method#120059
Conversation
|
I rebased the PR to fix a merge conflict. I addressed @eryksun's and @JelleZijlstra's reviews: thanks! |
|
@serhiy-storchaka @erlend-aasland: Would you mind to review this change? |
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
What about os.environb.refresh()? Does it exist? Does it work?
|
@serhiy-storchaka: I addressed your review. Would you mind to review my updated PR?
I added a test on os.environb.refresh(). Yes, it works as expected :-) |
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Should os.environb.refresh() be documented? We perhaps do not want to attract too much attention to it, as its effect is the same as of os.environ.refresh().
Test: use directly os.putenv().
Hum, I prefer to not document it at https://docs.python.org/dev/library/os.html#os.environb :-) |
|
(Ooops, I closed on [Close] instead of [Comment], sorry.) |
* Test os.unsetenv() * Document os.unsetenv() * Minor refactoring
|
@serhiy-storchaka: PR updated for os.unsetenv(). Oh, I didn't know that Python has two functions (putenv, unsetenv) which modify directly the environment without updating |
| to the environment made after this time are not reflected in :data:`os.environ`, | ||
| except for changes made by modifying :data:`os.environ` directly. | ||
|
|
||
| The :meth:`!os.environ.refresh()` method updates :data:`os.environ` with |
There was a problem hiding this comment.
FTR, the :meth: and :func: roles will implicitly add parentheses in the rendered output; you do not need to add them explicitly.
…)" This reverts commit 7aff2de. The function is controversial and it was decided to remove it.
6 participants
📚 Documentation preview 📚: https://cpython-previews--120059.org.readthedocs.build/