WebSafe 3.7github.com
|
|
🏠
Skip to content

gh-127146: Fix test_sysconfigdata_json for Emscripten#128556

Merged
FFY00 merged 1 commit intopython:mainfrom
hoodmane:sysconfig-test-2
Jan 6, 2025
Merged

gh-127146: Fix test_sysconfigdata_json for Emscripten#128556
FFY00 merged 1 commit intopython:mainfrom
hoodmane:sysconfig-test-2

Conversation

@hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Jan 6, 2025 •
edited by bedevere-app bot
Loading

We should set the value of prefix and exec_prefix in the host from host_prefix and host_exec_prefix.
@hoodmane
pythongh-127146: Fix test_sysconfigdata_json for Emscripten
a51b81d 
We should set the value of prefix and exec_prefix in the host from
host_prefix and host_exec_prefix.
@hoodmane hoodmane requested a review from FFY00 as a code owner January 6, 2025 19:14
@bedevere-app bedevere-app bot mentioned this pull request Jan 6, 2025
Closed
@hoodmane hoodmane requested a review from freakboy3742 January 6, 2025 19:14
@hoodmane hoodmane mentioned this pull request Jan 6, 2025
Closed
FFY00
FFY00 approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@FFY00 FFY00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Yes, I was just looking at this too when working on GH-128558. Good catch!
@FFY00 FFY00 merged commit b6c919b into python:main Jan 6, 2025
44 checks passed
@hoodmane hoodmane deleted the sysconfig-test-2 branch January 6, 2025 20:04
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@hoodmane @srinivasreddy
pythongh-127146: Fix test_sysconfigdata_json for Emscripten (python#1…
3124ddd 
…28556)
@hoodmane
Copy link
Contributor Author

hoodmane commented Jan 27, 2025

@Fy00 I'm still getting an error with a diff like:

-  'py_version_short': '3.14'}
+  'py_version_short': '3.14',
?                            ^
+  'userbase': '/home/rchatham/.local'}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news

2 participants

@hoodmane @FFY00

Comments