gh-93096: Remove -t and -v flags from pickletools cli#131039
Merged
vstinner merged 1 commit intopython:mainfrom Mar 11, 2025
Merged
gh-93096: Remove -t and -v flags from pickletools cli#131039vstinner merged 1 commit intopython:mainfrom
-t and -v flags from pickletools cli#131039vstinner merged 1 commit intopython:mainfrom
Conversation
donbarbos
changed the title
-t and -v flags from pickletools cli-t and -v flags from pickletools cli
27 tasks
Contributor
Author
|
I also made sure that unit tests call doctests, we add them here: cpython/Lib/test/test_pickletools.py Lines 517 to 519 in 98fa4a4 |
vstinner
approved these changes
Mar 11, 2025
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
I confirm that these options are not documented at: https://docs.python.org/dev/library/pickletools.html#command-line-usage
@serhiy-storchaka: Are you ok with removing these undocumented pickletools CLI options?
Contributor
Author
|
He commented this changes here: #130973 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm also going to send a similar PR for the
picklemodule (for same flags)And I'm not sure if I should send a separate PR or I can add it here