WebSafe 3.7github.com
|
|
🏠
Skip to content

gh-87790: support thousands separators for formatting fractional part of Fraction#132204

Merged
hugovk merged 2 commits intopython:mainfrom
skirpichev:frac-sep-Fraction/87790
Jul 7, 2025
Merged

gh-87790: support thousands separators for formatting fractional part of Fraction#132204
hugovk merged 2 commits intopython:mainfrom
skirpichev:frac-sep-Fraction/87790

Conversation

@skirpichev
Copy link
Member

@skirpichev skirpichev commented Apr 7, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Apr 7, 2025
Open
serhiy-storchaka
serhiy-storchaka reviewed Jul 3, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test also errors for '.f' and '.6_f'.
@skirpichev
Copy link
Member Author

skirpichev commented Jul 3, 2025

Test also errors for '.f' and '.6_f'.

I suspect you are about ._6f. This test was added in test_invalid_formats(). Missing precision already was tested.
@serhiy-storchaka serhiy-storchaka requested a review from hugovk July 3, 2025 13:02
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label Jul 3, 2025
serhiy-storchaka
serhiy-storchaka approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍
@hugovk hugovk changed the title gh-87790: support thousands separators for formatting fractional part of Fraction's gh-87790: support thousands separators for formatting fractional part of Fraction Jul 7, 2025
@hugovk hugovk merged commit 3e849d7 into python:main Jul 7, 2025
46 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Jul 7, 2025

Thanks @skirpichev for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
@miss-islington-app
Copy link

miss-islington-app bot commented Jul 7, 2025

Sorry, @skirpichev and @hugovk, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3e849d75f400569cbf3c29c356061c788284b71e 3.14
@skirpichev skirpichev deleted the frac-sep-Fraction/87790 branch July 7, 2025 08:58
@skirpichev skirpichev added needs backport to 3.14 bugs and security fixes and removed needs backport to 3.14 bugs and security fixes labels Jul 7, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Jul 7, 2025

Thanks @skirpichev for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
@miss-islington-app
Copy link

miss-islington-app bot commented Jul 7, 2025

Sorry, @skirpichev and @hugovk, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3e849d75f400569cbf3c29c356061c788284b71e 3.14
@serhiy-storchaka serhiy-storchaka added needs backport to 3.14 bugs and security fixes and removed needs backport to 3.14 bugs and security fixes labels Jul 7, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Jul 7, 2025

Thanks @skirpichev for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 7, 2025
@skirpichev @miss-islington
pythongh-87790: support thousands separators for formatting fractiona…
8e54f7a 
…l part of Fraction (pythonGH-132204)

(cherry picked from commit 3e849d7)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 7, 2025

GH-136364 is a backport of this pull request to the 3.14 branch.
@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 7, 2025
hugovk pushed a commit that referenced this pull request Jul 7, 2025
@miss-islington @skirpichev
[3.14] gh-87790: support thousands separators for formatting fraction…
442b781 
…al part of Fraction (GH-132204) (#136364)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@skirpichev @AndPuQing
pythongh-87790: support thousands separators for formatting fractiona…
d2730af 
…l part of Fraction (python#132204)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@skirpichev @Pranjal095
pythongh-87790: support thousands separators for formatting fractiona…
8c96584 
…l part of Fraction (python#132204)
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
@skirpichev @picnixz
pythongh-87790: support thousands separators for formatting fractiona…
51c7b1a 
…l part of Fraction (python#132204)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@skirpichev @taegyunkim
pythongh-87790: support thousands separators for formatting fractiona…
a9f7faa 
…l part of Fraction (python#132204)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@skirpichev @Agent-Hellboy
pythongh-87790: support thousands separators for formatting fractiona…
e5508f9 
…l part of Fraction (python#132204)
scoder added a commit to scoder/quicktions that referenced this pull request Sep 8, 2025
@scoder
Support thousands separators for formatting fractional part of Fraction.
5392ea2 
See python/cpython#132204
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@skirpichev @serhiy-storchaka @hugovk

Comments