gh-132983: Simplify _zstd_exec()#133775
Merged
AA-Turner merged 6 commits intopython:mainfrom May 9, 2025
Merged
Conversation
13 tasks
picnixz
reviewed
May 9, 2025
Member
picnixz
left a comment
picnixz
left a comment
There was a problem hiding this comment.
Overall, I think it's a nice improvement but usually, C classes are read-only (e.g., _sha2.SHA2Type does not allow setting class variables afterwards; the same holds for lzma.LZMACompressor so it would be better to do the same for the Zstd* types)
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
It would be better to make classes implemented in C immutable.
emmatyping
approved these changes
May 9, 2025
Member
emmatyping
left a comment
emmatyping
left a comment
There was a problem hiding this comment.
Thanks! These are great refactors.
picnixz
reviewed
May 9, 2025
Member
picnixz
left a comment
picnixz
left a comment
There was a problem hiding this comment.
You can add Py_TPFLAGS_IMMUTABLETYPE in this PR or in another.
picnixz
approved these changes
May 9, 2025
|
Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 9, 2025
(cherry picked from commit bbe9c31) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
|
GH-133786 is a backport of this pull request to the 3.14 branch. |
AA-Turner
added a commit
that referenced
this pull request
May 9, 2025
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @Rogdham (can't request review).
Follows on from #133670. Again best reviewed commit-by-commit. We remove around 100 lines of C code overall.
The last commit (
6a3a135(#133775)) only serves to merge two functions and contains no behaviour change, but does increase the diff size.add_type_to_module()function with anADD_TYPEmacro, usingPyModule_AddTypeinstead ofPyModule_AddObjectRef._zstdmodule.