WebSafe 3.7github.com
|
|
🏠
Skip to content

gh-132983: Fix zstd compiler warning about unused function mt_continue_should_break()#133947

Merged
AA-Turner merged 1 commit intopython:mainfrom
erlend-aasland:zstd-warning
May 12, 2025
Merged

gh-132983: Fix zstd compiler warning about unused function mt_continue_should_break()#133947
AA-Turner merged 1 commit intopython:mainfrom
erlend-aasland:zstd-warning

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 12, 2025

Fixes the following compiler warning:

./Modules/_zstd/compressor.c:490:1: warning: unused function 'mt_continue_should_break' [-Wunused-function]
  490 | mt_continue_should_break(ZSTD_inBuffer *in, ZSTD_outBuffer *out)
      | ^~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented May 12, 2025

AFAICS, mt_continue_should_break is only used in an assert, so we can safely only define it if we're debugging.

Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't see this compiler warning locally (do you need different flags for it?).

A

@AA-Turner AA-Turner added the needs backport to 3.14 bugs and security fixes label May 12, 2025
@AA-Turner AA-Turner merged commit 121ed71 into python:main May 12, 2025
48 checks passed
@miss-islington-app

This comment was marked as outdated.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 12, 2025
…inue_should_break()`` (pythonGH-133947)

(cherry picked from commit 121ed71)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-app
Copy link

bedevere-app bot commented May 12, 2025

GH-133950 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 12, 2025
@erlend-aasland erlend-aasland deleted the zstd-warning branch May 12, 2025 19:24
AA-Turner pushed a commit that referenced this pull request May 12, 2025
…tinue_should_break()`` (GH-133947) (#133950)

gh-132983: Fix compiler warning about unused function ``mt_continue_should_break()`` (GH-133947)
(cherry picked from commit 121ed71)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants

Comments