WebSafe 3.7github.com
|
|
🏠
Skip to content

gh-132983: Add zstd version info to test.pythoninfo#134230

Merged
vstinner merged 6 commits intopython:mainfrom
StanFromIreland:zstd-ver
May 19, 2025
Merged

gh-132983: Add zstd version info to test.pythoninfo#134230
vstinner merged 6 commits intopython:mainfrom
StanFromIreland:zstd-ver

Conversation

@StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented May 19, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request May 19, 2025
Closed
13 tasks
vstinner
vstinner approved these changes May 19, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have a minor PEP 8 remark. But the CI is failing.
@vstinner
Copy link
Member

vstinner commented May 19, 2025

Tests / Ubuntu / build and test (ubuntu-24.04) (pull_request)Failing after 3m

Unexpected warnings:
Include/opcode_ids.h expected 0 warnings, found 2
{'file': 'Include/opcode_ids.h', 'line': '132', 'column': '48', 'message': 'initialized field overwritten', 'option': '-Woverride-init'}
{'file': 'Include/opcode_ids.h', 'line': '133', 'column': '48', 'message': 'initialized field overwritten', 'option': '-Woverride-init'}
@StanFromIreland
Copy link
Member Author

StanFromIreland commented May 19, 2025

Fails are unrelated from what I can tell, most should be resolved by updating the branch as pr's fixing have been merged.

Docs test will fail, but it is fine since #133911 will be merged soon enough.
@StanFromIreland
Copy link
Member Author

StanFromIreland commented May 19, 2025

Yep, all [excluding expected fail] test pass.
@vstinner
Copy link
Member

vstinner commented May 19, 2025

I clicked on [Update branch] to try to repair the CI.
@vstinner
Copy link
Member

vstinner commented May 19, 2025

@StanFromIreland: There is an issue in the doc:

/home/runner/work/cpython/cpython/Doc/build/NEWS:74: WARNING: py:mod reference target not found: compression.zstd [ref.mod]
@StanFromIreland @vstinner
Update Misc/NEWS.d/next/Library/2025-05-19-15-30-00.gh-issue-132983.a…
4d38115 
…sdsfs.rst

Co-authored-by: Victor Stinner <vstinner@python.org>
@vstinner vstinner merged commit 46d7c11 into python:main May 19, 2025
39 checks passed
@vstinner
Copy link
Member

vstinner commented May 19, 2025

Merged, thanks.
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@StanFromIreland @vstinner @Pranjal095
pythongh-132983: Add zstd version info to test.pythoninfo (python#1…
7248a02 
…34230)

Co-authored-by: Victor Stinner <vstinner@python.org>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@StanFromIreland @vstinner @taegyunkim
pythongh-132983: Add zstd version info to test.pythoninfo (python#1…
8f0d01f 
…34230)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@StanFromIreland @vstinner @emmatyping

Comments