gh-137044: Revert "gh-137044: Make resource.RLIM_INFINITY always positive (GH-137511)"#137938
Closed
encukou wants to merge 1 commit intopython:mainfrom
Closed
gh-137044: Revert "gh-137044: Make resource.RLIM_INFINITY always positive (GH-137511)"#137938encukou wants to merge 1 commit intopython:mainfrom
encukou wants to merge 1 commit intopython:mainfrom
Conversation
…ythonGH-137511)" This reverts commit 0324c72.
encukou
changed the title
Member
|
No, I think that we should just fix the tests. The behavior on 32-bit Linux is documented, I just don't have 32-bit Linux for testing now and missed the buildbot failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 0324c72.
@serhiy-storchaka: #137511 broke buildbots, and I'm worried about the misunderstanding in #137044 (comment)
I think it's best to revert now, so we don't need to rush a good fix. Do you agree?
📚 Documentation preview 📚: https://cpython-previews--137938.org.readthedocs.build/