WebSafe 3.7github.com
|
|
🏠
Skip to content

gh-141004: deprecate Py_MATH_El and Py_MATH_PIl macros#141035

Merged
vstinner merged 4 commits intopython:mainfrom
skirpichev:deprecate-consts/141004
Nov 10, 2025
Merged

gh-141004: deprecate Py_MATH_El and Py_MATH_PIl macros#141035
vstinner merged 4 commits intopython:mainfrom
skirpichev:deprecate-consts/141004

Conversation

@skirpichev
Copy link
Member

@skirpichev skirpichev commented Nov 5, 2025 •
edited by github-actions bot
Loading

@skirpichev skirpichev requested a review from AA-Turner as a code owner November 5, 2025 02:54
@bedevere-app bedevere-app bot mentioned this pull request Nov 5, 2025
Open
@skirpichev
Copy link
Member Author

skirpichev commented Nov 5, 2025

CC @ZeroIntensity, @vstinner
vstinner
vstinner reviewed Nov 5, 2025
View reviewed changes
@skirpichev @vstinner
Apply suggestions from code review
fd0ebd8 
Co-authored-by: Victor Stinner <vstinner@python.org>
@vstinner
Copy link
Member

vstinner commented Nov 5, 2025

A code search in PyPI top 15,000 found no matching line:

$ ./search_pypi_top.py PYPI-2025-09-22/ 'Py_MATH_PIl|Py_MATH_El' -o Py_MATH_PIl -q

Time: 0:01:39.505584
Found 0 matching lines in 0 projects
Output written into: Py_MATH_PIl
vstinner
vstinner approved these changes Nov 5, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
ZeroIntensity
ZeroIntensity approved these changes Nov 5, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well.
@vstinner vstinner merged commit 88953d5 into python:main Nov 10, 2025
46 checks passed
@skirpichev skirpichev deleted the deprecate-consts/141004 branch November 11, 2025 10:27
@skirpichev skirpichev mentioned this pull request Nov 11, 2025
Merged
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@skirpichev @vstinner @StanFromIreland
pythongh-141004: Deprecate Py_MATH_El and Py_MATH_PIl macros (python#…
ed146ad 
…141035)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@skirpichev @vstinner @ZeroIntensity

Comments