WebSafe 3.7github.com
|
|
🏠
Skip to content

[3.11] gh-98548: Fix -ne shell operator spelling#98556

Merged
ambv merged 2 commits intopython:3.11from
sterliakov:gh-98548-3.11
Oct 28, 2022
Merged

[3.11] gh-98548: Fix -ne shell operator spelling#98556
ambv merged 2 commits intopython:3.11from
sterliakov:gh-98548-3.11

Conversation

@sterliakov
Copy link
Contributor

@sterliakov sterliakov commented Oct 22, 2022

gh-98548: Workflow not equal operator spelling

This shell operator should be spelled as -ne, not as -neq. All shell binary operators are two symbols long.

This bug is present on 3.10 and 3.11 branches only.

This follows #98555 for another affected branch.
@bedevere-bot
Copy link

bedevere-bot commented Oct 22, 2022

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.
hauntsaninja
hauntsaninja reviewed Oct 23, 2022
View reviewed changes
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this!

Here is an example workflow run affected: https://github.com/python/cpython/actions/runs/3293756628/jobs/5430563962
That said, I'm not sure this is enough of a fix, because I think Github Actions runs with bash -e. So I think we'd never get to this anyway? One option would be to use || (echo ... ; exit 1) or something
@hauntsaninja hauntsaninja mentioned this pull request Oct 23, 2022
Merged
@sterliakov
Copy link
Contributor Author

sterliakov commented Oct 24, 2022

Since the command expected to fail is short enough, maybe just

if ! make check-abidump; then
    echo ...
fi

is sufficient? The if and until conditions are not considered failing for -e. Yes, gihub actions use set -e (or bash -e, not sure about this) to fail on first failing step.
@sterliakov sterliakov requested review from hauntsaninja and removed request for ezio-melotti October 24, 2022 10:09
hauntsaninja
hauntsaninja approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me. Want to update the 3.10 backport #98555 as well? :-) cc @JelleZijlstra
@JelleZijlstra JelleZijlstra self-assigned this Oct 25, 2022
@sterliakov
Copy link
Contributor Author

sterliakov commented Oct 25, 2022

Updated #98555 too.
@ambv ambv merged commit 194588d into python:3.11 Oct 28, 2022
encukou pushed a commit to encukou/cpython that referenced this pull request May 23, 2023
@pablogsal @sterliakov @encukou
[3.12] Add CI step to check changes in the exported ABI (python#92442)
1aeeebd 
Backport the workflow change and fix-ups:
- pythonGH-92442 (e89c01e)
- pythonGH-94129 (0dadb22)
- pythonGH-98556 (194588d)

Co-Authored-By: sterliakov <50529348+sterliakov@users.noreply.github.com>
@encukou encukou mentioned this pull request May 23, 2023
Merged
Yhg1s pushed a commit that referenced this pull request May 23, 2023
@encukou @sterliakov
@hugovk @pablogsal
[3.12] gh-87891: Add ABI check to CI (#104793)
b44beac 
Backport the workflow change and fix-ups:
- GH-92442 (e89c01e)
- GH-94129 (0dadb22)
- GH-98556 (194588d)

Co-Authored-By: sterliakov <50529348+sterliakov@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news

6 participants

@sterliakov @bedevere-bot @hauntsaninja @ambv @JelleZijlstra @AlexWaygood

Comments