gh-99284: [ctypes] remove _use_broken_old_ctypes_structure_semantics_#99285
gh-99284: [ctypes] remove _use_broken_old_ctypes_structure_semantics_#99285gpshead merged 4 commits intopython:mainfrom
_use_broken_old_ctypes_structure_semantics_#99285Conversation
sobolevn
changed the title
_use_broken_old_ctypes_structure_semantics_
sobolevn
changed the title
_use_broken_old_ctypes_structure_semantics__use_broken_old_ctypes_structure_semantics_
|
I've messed up the issue number, sorry! |
|
Looks like this hack was added in ~2006. Some research of existing code to see if anything still relies on it is warranted before merging, it seems very unlikely. if so we'd want a deprecation period. |
|
Quoting the original issue:
I've done a minimal research. I was not able to find any references to it. I don't feel qualified in this specific module and its history to make an educated decision here. However, deprecation period is always a good idea 👍 |
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM, but please complete the doc.
This attribute was untested and undocumented. I never heard about it.
Looks like not a single GitHub project uses it.
I ran a code search in PyPI top 5000 projects: no projects use it.
$ ./search_pypi_top.py PYPI-2020-09-01/ '_use_broken_old_ctypes_structure_semantics_' -q
Found 0 matching lines in 0 projects
Misc/NEWS.d/next/Library/2022-11-09-12-36-12.gh-issue-99284.9p4J2l.rst
Outdated
Show resolved
Hide resolved
sobolevn
force-pushed
the
issue-99284
branch
from
7f45ebc to
1388dd0
Compare
gpshead
left a comment
gpshead
left a comment
There was a problem hiding this comment.
Thanks! FWIW I also searched our huge internal codebase at Google, nothing found that uses this odd thing.
4 participants
_use_broken_old_ctypes_structure_semantics_? #99284