Add duplicate package detection to rewatch#8180
Merged
nojaf merged 6 commits intorescript-lang:masterfrom Jan 16, 2026
Merged
Conversation
cknitt
reviewed
Jan 16, 2026
| const { stdout, stderr } = await execBuild(); | ||
|
|
||
| const expectedWarning = | ||
| "Duplicated package: z ./node_modules/z (chosen) vs ./a/node_modules/z in ./a"; |
Member
There was a problem hiding this comment.
The check in bsb was taking symlinks into account according to https://github.com/rescript-lang/rescript/blob/86814cea6e8dfd9dbf756a70a2e6c4964a7c5a60/tests/build_tests/duplicated_symlinked_packages/README.md.
Is the check here also doing that? I.e., is it only warning about z or about other packages, too?
Member
Author
There was a problem hiding this comment.
Yes, I believe so, as we use canonicalize()
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
cknitt
approved these changes
Jan 16, 2026
cknitt
pushed a commit
that referenced
this pull request
Jan 26, 2026
* Add duplicate package detection to rewatch * Add changelog * Warn to stderr * Set runtime env var * fmt
cknitt
pushed a commit
that referenced
this pull request
Jan 27, 2026
* Add duplicate package detection to rewatch * Add changelog * Warn to stderr * Set runtime env var * fmt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8178