fix(snapshot): changed insert to upsert when concurrent identical child workflows are running#3259
Merged
waleedlatif1 merged 2 commits intostagingfrom Feb 19, 2026
Merged
fix(snapshot): changed insert to upsert when concurrent identical child workflows are running#3259waleedlatif1 merged 2 commits intostagingfrom
waleedlatif1 merged 2 commits intostagingfrom
Conversation
…ld workflows are running
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryFixes race condition in concurrent snapshot creation by replacing SELECT-then-INSERT pattern with atomic upsert operation. Key changes:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant C1 as Concurrent Request 1
participant C2 as Concurrent Request 2
participant DB as PostgreSQL Database
Note over C1,C2: Both compute same stateHash for identical workflows
C1->>DB: INSERT with UUID-1<br/>ON CONFLICT (workflowId, stateHash)<br/>DO UPDATE SET stateData
C2->>DB: INSERT with UUID-2<br/>ON CONFLICT (workflowId, stateHash)<br/>DO UPDATE SET stateData
Note over DB: Unique index on (workflowId, stateHash)<br/>ensures atomicity
alt First request wins
DB-->>C1: Returns snapshot with UUID-1
DB-->>C2: Returns existing snapshot with UUID-1
Note over C1: isNew = true (UUID matches)
Note over C2: isNew = false (UUID differs)
else Second request wins
DB-->>C2: Returns snapshot with UUID-2
DB-->>C1: Returns existing snapshot with UUID-2
Note over C2: isNew = true (UUID matches)
Note over C1: isNew = false (UUID differs)
end
Last reviewed commit: fd967b2 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Collaborator
Author
|
@cursor agent |
|
Taking a look! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested manually
Checklist