scikit-learn import and comment fix#1485
Merged
mravanelli merged 19 commits intospeechbrain:developfrom Nov 3, 2022
Merged
Conversation
Collaborator
|
Thank you @underdogliu :D Please run linters & update this one too (hope I didn't miss it) |
nauman-daw
suggested changes
Jun 28, 2022
Collaborator
nauman-daw
left a comment
nauman-daw
left a comment
There was a problem hiding this comment.
Thanks @underdogliu
Kindly make the necessary changes to pass all the tests. They are mostly minor syntax updates.
These changes looks good to me.
@mravanelli this PR can be merged once all the tests are passed.
Collaborator
Author
|
@mravanelli Some of my changes on voxceleb2 results today are merged with this PR, as we discussed. Just for your information. I would not open another PR. |
anautsch
reviewed
Aug 30, 2022
anautsch
reviewed
Aug 30, 2022
anautsch
reviewed
Aug 30, 2022
Collaborator
|
Hello, Is there any news on this PR, please? 😃 |
Collaborator
|
Hi @underdogliu, could you pelease fix the linters and the faling tests? |
Collaborator
Author
|
@mravanelli @anautsch all tests have been passed. |
mravanelli
approved these changes
Nov 3, 2022
Collaborator
|
Thank you @underdogliu! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related with issue #1484
I found in our diarization-related scripts and runners, we ask the users to install
sklearn, instead ofscikit-learn.sklearn, on pip, as pointed out in the issue, is a void package whilescikit-learnis the library we want. Of course, in the python scripts, it is still imported asimport sklearn.Tests have been done via pip and conda. For conda actually, we can't even find
sklearn.Note: seems like this PR contains some un-necessary changes due to my black accent plugin in my vscode....if necessary I can check them out.