Conversation
Collaborator
|
Thank you @anautsch, thank you for this improvement. I re-run all the tests and everything seems to work as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made a few clean-ups on tests:
tests/tmp(if not in other temporary folders outside of the local repo)tests/tmp/rir(aim: regardless of which test runs, it's 1.3 Gb each time for the same archive - so, recipes can refer to the same download destination and skip if existing already)Some recipes were adjusted (minor edits).
#1469 - test for profiling adjusted: CUDA presence issues recording of events, although PyTorch profiler with warming-up scheduler schould not record anything (but it does) ... during testing, these events were simply removed from the list to not interfer with PyTorch profiler's doings - we provide a wrapper only.