Conversation
tiny-ben-tran
requested review from
a team,
MitchC1999,
kimwoodfield,
shanmen-tiny and
soritaheng
and removed request for
a team
tiny-ben-tran
requested review from
TheSpyder,
ltrouton and
spocke
and removed request for
a team
jscasca
reviewed
Feb 19, 2026
Contributor
jscasca
left a comment
jscasca
left a comment
There was a problem hiding this comment.
I would make some changes to the jenkinsfile before moving forward
| // Updates the Angular dependencies to the version specified by the npm tag | ||
| def updateDependenciesWithTag(Map args = new LinkedHashMap()) { | ||
| String npm_tag = args.npm_tag | ||
| sh "yarn add @angular/core@${npm_tag} @angular/animations@${npm_tag} @angular/common@${npm_tag} @angular/compiler@${npm_tag} @angular/core@${npm_tag} @angular/forms@${npm_tag} @angular/platform-browser@${npm_tag} @angular-devkit/build-angular@${npm_tag} @angular/cli@${npm_tag} @angular/compiler-cli@${npm_tag}" |
Contributor
There was a problem hiding this comment.
that's one way of doing it, I guess 🤔
Contributor
Author
There was a problem hiding this comment.
it could be made easier/nicer if ng update command could resolve with private/local packages ie: tinymce-4, tinymce-5, etc. At the moment, it just throws not found error because it tries to fetch the packages from NPM
kimwoodfield
approved these changes
Feb 19, 2026
Contributor
kimwoodfield
left a comment
kimwoodfield
left a comment
There was a problem hiding this comment.
The logic makes sense to me. I'm happy to pre-approve based on @jscasca review 👍🏻
tiny-ben-tran
force-pushed
the
feature/INT-3399
branch
from
e940418 to
4f618dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related ticket: INT-3399
Description of changes: